Checkstyle Results

The following document contains the results of Checkstyle.

Summary

Files

au/com/loftinspace/tcpreflector/Reflector.java

Error		Line
	Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'.	1
	Line contains a tab character.	17
	Missing a Javadoc comment.	17
	Line contains a tab character.	18
	Missing a Javadoc comment.	18
	Line contains a tab character.	19
	Missing a Javadoc comment.	19
	Line contains a tab character.	20
	Missing a Javadoc comment.	20
	Line is longer than 80 characters.	22
	Missing a Javadoc comment.	22
	Parameter clientSocket should be final.	22
	'clientSocket' hides a field.	22
	Parameter destinationSocket should be final.	22
	'destinationSocket' hides a field.	22
	Line contains a tab character.	23
	Line contains a tab character.	24
	Line is longer than 80 characters.	25
	Line contains a tab character.	25
	Line is longer than 80 characters.	26
	Line contains a tab character.	26
	Line is longer than 80 characters.	27
	Line is longer than 80 characters.	28
	Line contains a tab character.	28
	Line contains a tab character.	29
	Line contains a tab character.	31
	Method 'startReflecting' is not designed for extension - needs to be abstract, final or empty.	31
	Missing a Javadoc comment.	31
	Line contains a tab character.	32
	'+' should be on a new line.	32
	Line is longer than 80 characters.	33
	Line contains a tab character.	33
	'+' should be on a new line.	33
	Line is longer than 80 characters.	34
	Line contains a tab character.	34
	Line has trailing spaces.	35
	Line contains a tab character.	35
	Line contains a tab character.	36
	'+' should be on a new line.	36
	Line is longer than 80 characters.	37
	Line contains a tab character.	37
	'+' should be on a new line.	37
	Line is longer than 80 characters.	38
	Line contains a tab character.	38
	Line has trailing spaces.	39
	Line contains a tab character.	39
	Line is longer than 80 characters.	40
	Line contains a tab character.	40
	Line is longer than 80 characters.	41
	Line contains a tab character.	41
	Line contains a tab character.	42
	Line has trailing spaces.	43
	Line contains a tab character.	43
	Line contains a tab character.	44
	Method 'waitForCompletion' is not designed for extension - needs to be abstract, final or empty.	44
	Missing a Javadoc comment.	44
	Line contains a tab character.	45
	Line contains a tab character.	47
	'250' is a magic number.	47
	Line contains a tab character.	48
	'catch' is not followed by whitespace.	48
	Must have at least one statement.	48
	Line contains a tab character.	49
	Line contains a tab character.	50
	Line contains a tab character.	52
	Line has trailing spaces.	53
	Line contains a tab character.	53
	Line contains a tab character.	54
	Method 'terminateInterceptors' is not designed for extension - needs to be abstract, final or empty.	54
	Missing a Javadoc comment.	54
	Line contains a tab character.	63
	Missing a Javadoc comment.	65
	Parameter socket should be final.	65
	Must have at least one statement.	70
	Missing a Javadoc comment.	74
	Line is longer than 80 characters.	75
	Line contains a tab character.	78
	Method 'addListener' is not designed for extension - needs to be abstract, final or empty.	78
	Missing a Javadoc comment.	78
	Parameter listener should be final.	78
	Line contains a tab character.	79
	Line contains a tab character.	80
	Line contains a tab character.	81
	Line has trailing spaces.	82
	Line contains a tab character.	82
	Line contains a tab character.	83
	Method 'removeListener' is not designed for extension - needs to be abstract, final or empty.	83
	Missing a Javadoc comment.	83
	Parameter listener should be final.	83
	Line contains a tab character.	84
	Line contains a tab character.	85
	Line contains a tab character.	86
	Method 'setReflective' is not designed for extension - needs to be abstract, final or empty.	88
	Missing a Javadoc comment.	88
	Parameter reflective should be final.	88
	Method 'setResponseReflective' is not designed for extension - needs to be abstract, final or empty.	93
	Missing a Javadoc comment.	93
	Parameter reflective should be final.	93
	Method 'removeAllListeners' is not designed for extension - needs to be abstract, final or empty.	97
	Missing a Javadoc comment.	97

au/com/loftinspace/tcpreflector/TcpReflector.java

Error		Line
	Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'.	1
	Line is longer than 80 characters.	17
	Missing a Javadoc comment.	22
	Missing a Javadoc comment.	24
	Missing a Javadoc comment.	25
	Missing a Javadoc comment.	26
	Missing a Javadoc comment.	27
	Missing a Javadoc comment.	28
	Missing a Javadoc comment.	29
	Missing a Javadoc comment.	30
	Missing a Javadoc comment.	31
	Missing a Javadoc comment.	32
	Line is longer than 80 characters.	34
	Missing a Javadoc comment.	34
	Parameter listeningPort should be final.	34
	'listeningPort' hides a field.	34
	Parameter destination should be final.	34
	'destination' hides a field.	34
	Method 'run' is not designed for extension - needs to be abstract, final or empty.	44
	Missing a Javadoc comment.	44
	Must have at least one statement.	49
	Line is longer than 80 characters.	57
	Line contains a tab character.	59
	Line contains a tab character.	60
	Method 'setReflective' is not designed for extension - needs to be abstract, final or empty.	62
	Parameter reflective should be final.	62
	'reflective' hides a field.	62
	'cast' is not followed by whitespace.	65
	Line contains a tab character.	74
	Line contains a tab character.	75
	Method 'setResponseReflective' is not designed for extension - needs to be abstract, final or empty.	77
	Parameter reflective should be final.	77
	'reflective' hides a field.	77
	'cast' is not followed by whitespace.	80
	Line contains a tab character.	89
	Line contains a tab character.	90
	Method 'isReflective' is not designed for extension - needs to be abstract, final or empty.	92
	Line is longer than 80 characters.	97
	Method 'getPacketListeners' is not designed for extension - needs to be abstract, final or empty.	101
	Line is longer than 80 characters.	106
	Line is longer than 80 characters.	107
	Method 'addListener' is not designed for extension - needs to be abstract, final or empty.	110
	Parameter listener should be final.	110
	Expected @param tag for 'listener'.	110
	Line is longer than 80 characters.	120
	Line is longer than 80 characters.	121
	Method 'removeListener' is not designed for extension - needs to be abstract, final or empty.	124
	Parameter listener should be final.	124
	Expected @param tag for 'listener'.	124
	Line is longer than 80 characters.	134
	Line is longer than 80 characters.	135
	Line is longer than 80 characters.	136
	Method 'removeAllListeners' is not designed for extension - needs to be abstract, final or empty.	139
	Method 'getDestination' is not designed for extension - needs to be abstract, final or empty.	153
	Line is longer than 80 characters.	158
	Method 'setDestination' is not designed for extension - needs to be abstract, final or empty.	163
	Parameter destination should be final.	163
	'destination' hides a field.	163
	Line is longer than 80 characters.	168
	Method 'isConnective' is not designed for extension - needs to be abstract, final or empty.	173
	Line is longer than 80 characters.	178
	Line is longer than 80 characters.	179
	Line is longer than 80 characters.	182
	Line is longer than 80 characters.	187
	Method 'setConnective' is not designed for extension - needs to be abstract, final or empty.	190
	Parameter connective should be final.	190
	'connective' hides a field.	190
	Method 'shutdown' is not designed for extension - needs to be abstract, final or empty.	210
	Must have at least one statement.	217
	'cast' is not followed by whitespace.	223
	Missing a Javadoc comment.	229
	Line is longer than 80 characters.	242
	Missing a Javadoc comment.	253
	Missing a Javadoc comment.	258
	Missing a Javadoc comment.	263
	Line is longer than 80 characters.	265
	'100L' is a magic number.	266
	Line is longer than 80 characters.	269
	Must have at least one statement.	273
	Line is longer than 80 characters.	277
	'100L' is a magic number.	278
	Missing a Javadoc comment.	283
	Parameter duration should be final.	283
	Must have at least one statement.	286

au/com/loftinspace/tcpreflector/TcpReflectorExecutor.java

Error		Line
	Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'.	1
	Unused import - java.util.ArrayList.	9
	Line is longer than 80 characters.	13
	Missing a Javadoc comment.	37
	Missing a Javadoc comment.	38
	Missing a Javadoc comment.	39
	Missing a Javadoc comment.	40
	Missing a Javadoc comment.	41
	Line is longer than 80 characters.	52
	Parameter listeningPort should be final.	52
	Parameter destination should be final.	52
	'destination' hides a field.	52
	Parameter packetListeners should be final.	53
	Line is longer than 80 characters.	60
	Missing a Javadoc comment.	60
	Parameter listeningPort should be final.	60
	Parameter destination should be final.	60
	'destination' hides a field.	60
	Line is longer than 80 characters.	62
	Line is longer than 80 characters.	68
	Method 'allowConnections' is not designed for extension - needs to be abstract, final or empty.	68
	Missing a Javadoc comment.	68
	Parameter allow should be final.	68
	First sentence should end with a period.	76
	Method 'allowResponsePassage' is not designed for extension - needs to be abstract, final or empty.	80
	Parameter comms should be final.	80
	Expected @param tag for 'comms'.	80
	Missing a Javadoc comment.	86
	'100L' is a magic number.	97
	Must have at least one statement.	98
	Missing a Javadoc comment.	103
	Must have at least one statement.	108
	Missing a Javadoc comment.	116
	'64' is a magic number.	117
	Missing a Javadoc comment.	128
	Parameter packetListeners should be final.	128
	Line is longer than 80 characters.	129
	Line is longer than 80 characters.	131
	'+' should be on a new line.	131
	Missing a Javadoc comment.	137
	Line is longer than 80 characters.	139

au/com/loftinspace/tcpreflector/TcpReflectorMain.java

Error		Line
	Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'.	1
	First sentence should end with a period.	9
	Utility classes should not have a public or default constructor.	14
	Missing a Javadoc comment.	15
	Missing a Javadoc comment.	16
	Missing a Javadoc comment.	17
	Missing a Javadoc comment.	18
	Missing a Javadoc comment.	19
	Missing a Javadoc comment.	20
	Missing a Javadoc comment.	21
	Missing a Javadoc comment.	23
	Missing a Javadoc comment.	24
	Missing a Javadoc comment.	25
	Missing a Javadoc comment.	27
	Parameter args should be final.	27
	Line is longer than 80 characters.	29
	Missing a Javadoc comment.	35
	Parameter args should be final.	35
	Missing a Javadoc comment.	66
	Parameter argument should be final.	66
	Line is longer than 80 characters.	67
	Missing a Javadoc comment.	73
	Parameter argument should be final.	73
	Missing a Javadoc comment.	81
	Parameter argument should be final.	81
	Missing a Javadoc comment.	91
	Parameter args should be final.	91
	Parameter index should be final.	91
	Missing a Javadoc comment.	97
	Parameter reflectorSpawner should be final.	97
	Missing a Javadoc comment.	106
	Line is longer than 80 characters.	107
	Missing a Javadoc comment.	110
	Parameter exitCode should be final.	110
	Line is longer than 80 characters.	112
	Line is longer than 80 characters.	114
	Line is longer than 80 characters.	115
	Line is longer than 80 characters.	116
	Line is longer than 80 characters.	117

au/com/loftinspace/tcpreflector/io/InterceptorManager.java

Error		Line
	Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'.	1
	First sentence should end with a period.	3
	Missing a Javadoc comment.	9
	Redundant 'public' modifier.	9

au/com/loftinspace/tcpreflector/io/PacketInterceptor.java

Error		Line
	Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'.	1
	First sentence should end with a period.	13
	Missing a Javadoc comment.	19
	Missing a Javadoc comment.	21
	Missing a Javadoc comment.	22
	Missing a Javadoc comment.	23
	Missing a Javadoc comment.	24
	Missing a Javadoc comment.	25
	Missing a Javadoc comment.	26
	Missing a Javadoc comment.	27
	Missing a Javadoc comment.	28
	Missing a Javadoc comment.	29
	Line is longer than 80 characters.	31
	Missing a Javadoc comment.	31
	Parameter inputStream should be final.	31
	'inputStream' hides a field.	31
	Parameter outputStream should be final.	31
	'outputStream' hides a field.	31
	Parameter interceptorManager should be final.	31
	'interceptorManager' hides a field.	31
	Parameter fromAddress should be final.	31
	'fromAddress' hides a field.	31
	Parameter toAddress should be final.	31
	'toAddress' hides a field.	31
	Method 'addListener' is not designed for extension - needs to be abstract, final or empty.	43
	Missing a Javadoc comment.	43
	Parameter listener should be final.	43
	Method 'removeListener' is not designed for extension - needs to be abstract, final or empty.	47
	Missing a Javadoc comment.	47
	Parameter listener should be final.	47
	Method 'removeAllListeners' is not designed for extension - needs to be abstract, final or empty.	51
	Missing a Javadoc comment.	51
	Method 'getListenerCount' is not designed for extension - needs to be abstract, final or empty.	55
	Missing a Javadoc comment.	55
	Method 'run' is not designed for extension - needs to be abstract, final or empty.	59
	Missing a Javadoc comment.	59
	Method 'terminate' is not designed for extension - needs to be abstract, final or empty.	69
	Missing a Javadoc comment.	69
	Method 'isActive' is not designed for extension - needs to be abstract, final or empty.	75
	Missing a Javadoc comment.	75
	Missing a Javadoc comment.	79
	Line is longer than 80 characters.	87
	Missing a Javadoc comment.	93
	Parameter inputStream should be final.	93
	'inputStream' hides a field.	93
	Must have at least one statement.	98
	Missing a Javadoc comment.	102
	Parameter outputStream should be final.	102
	'outputStream' hides a field.	102
	Must have at least one statement.	107
	Missing a Javadoc comment.	111
	Parameter packet should be final.	111
	Method 'setReflective' is not designed for extension - needs to be abstract, final or empty.	119
	Missing a Javadoc comment.	119
	Parameter reflective should be final.	119
	'reflective' hides a field.	119

au/com/loftinspace/tcpreflector/io/package.html

Error		Line
	Missing package documentation file.	0

au/com/loftinspace/tcpreflector/package.html

Error		Line
	Missing package documentation file.	0

au/com/loftinspace/tcpreflector/packet/AsciiLoggingPacketListener.java

Error		Line
	Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'.	1
	First sentence should end with a period.	8
	Line contains a tab character.	8
	Line contains a tab character.	9
	Line contains a tab character.	10
	Line contains a tab character.	11
	Method 'processPacket' is not designed for extension - needs to be abstract, final or empty.	11
	Parameter packet should be final.	11
	Expected @param tag for 'packet'.	11
	Line is longer than 80 characters.	12
	'+' is not preceded with whitespace.	12
	'+' is not followed by whitespace.	12
	'+' is not preceded with whitespace.	12
	'+' is not followed by whitespace.	12
	Line contains a tab character.	13
	Line contains a tab character.	14
	Line contains a tab character.	15

au/com/loftinspace/tcpreflector/packet/BinaryLoggingPacketListener.java

Error		Line
	Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'.	1
	Missing a Javadoc comment.	3
	First sentence should end with a period.	5
	Line contains a tab character.	5
	Line contains a tab character.	6
	Line contains a tab character.	7
	Line contains a tab character.	8
	Method 'processPacket' is not designed for extension - needs to be abstract, final or empty.	8
	Parameter packet should be final.	8
	Expected @param tag for 'packet'.	8
	Line contains a tab character.	9
	Line is longer than 80 characters.	10
	'+' is not preceded with whitespace.	10
	'+' is not followed by whitespace.	10
	'+' is not preceded with whitespace.	10
	'+' is not followed by whitespace.	10
	Line contains a tab character.	11
	'16' is a magic number.	11
	Line contains a tab character.	12
	Line contains a tab character.	13
	Line contains a tab character.	15
	Line contains a tab character.	17
	Missing a Javadoc comment.	17
	Parameter start should be final.	17
	Parameter bytes should be final.	17
	Line contains a tab character.	18
	'128' is a magic number.	18
	Line has trailing spaces.	19
	Line contains a tab character.	19
	Line contains a tab character.	20
	'16' is a magic number.	20
	Line contains a tab character.	21
	Line contains a tab character.	24
	Line contains a tab character.	25
	Line contains a tab character.	26
	Line contains a tab character.	27
	Line contains a tab character.	28
	Line contains a tab character.	32
	'16' is a magic number.	32
	Line contains a tab character.	33
	Line contains a tab character.	35
	Line contains a tab character.	36
	Line contains a tab character.	37
	Line has trailing spaces.	38
	Line contains a tab character.	38
	Line contains a tab character.	39
	Line contains a tab character.	40
	Missing a Javadoc comment.	42
	Parameter aByte should be final.	42
	'32' is a magic number.	43
	Avoid inline conditionals.	43
	'cast' is not followed by whitespace.	43
	Missing a Javadoc comment.	46
	Parameter anInt should be final.	46
	'128' is a magic number.	47
	Line is longer than 80 characters.	48
	'16' is a magic number.	48
	Avoid inline conditionals.	48

au/com/loftinspace/tcpreflector/packet/Packet.java

Error		Line
	Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'.	1
	First sentence should end with a period.	5
	Missing a Javadoc comment.	11
	Missing a Javadoc comment.	12
	Missing a Javadoc comment.	13
	Line is longer than 80 characters.	15
	Missing a Javadoc comment.	15
	Parameter bytes should be final.	15
	'bytes' hides a field.	15
	Parameter bytesRead should be final.	15
	Parameter fromAddress should be final.	15
	'fromAddress' hides a field.	15
	Parameter toAddress should be final.	15
	'toAddress' hides a field.	15
	Method 'getBytes' is not designed for extension - needs to be abstract, final or empty.	29
	Missing a Javadoc comment.	29
	Method 'getFromAddress' is not designed for extension - needs to be abstract, final or empty.	33
	Missing a Javadoc comment.	33
	Method 'getToAddress' is not designed for extension - needs to be abstract, final or empty.	37
	Missing a Javadoc comment.	37
	Method 'hashCode' is not designed for extension - needs to be abstract, final or empty.	41
	Missing a Javadoc comment.	41
	Method 'getSize' is not designed for extension - needs to be abstract, final or empty.	45
	Missing a Javadoc comment.	45

au/com/loftinspace/tcpreflector/packet/PacketListener.java

Error		Line
	Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'.	1
	Missing a Javadoc comment.	14
	Missing a Javadoc comment.	15
	Variable 'packets' must be private and have accessor methods.	15
	Missing a Javadoc comment.	17
	Missing a Javadoc comment.	24
	Missing a Javadoc comment.	34
	'100L' is a magic number.	36
	Must have at least one statement.	37
	Missing a Javadoc comment.	42
	Parameter packet should be final.	42
	Missing a Javadoc comment.	46
	Method 'toString' is not designed for extension - needs to be abstract, final or empty.	50
	Missing a Javadoc comment.	50
	Line is longer than 80 characters.	63
	Parameter packet should be final.	66
	Expected @param tag for 'packet'.	66

au/com/loftinspace/tcpreflector/packet/package.html

Error		Line
	Missing package documentation file.	0

au/com/loftinspace/utility/FileLoader.java

Error		Line
	Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'.	1
	Utility classes should not have a public or default constructor.	11
	Line contains a tab character.	13
	Line contains a tab character.	14
	Line contains a tab character.	15
	Line contains a tab character.	16
	Line contains a tab character.	17
	Line contains a tab character.	18
	Line contains a tab character.	19
	Line contains a tab character.	20
	Line contains a tab character.	21
	Parameter filename should be final.	21
	Line contains a tab character.	22
	'1024' is a magic number.	22
	Line contains a tab character.	23
	'1024' is a magic number.	23
	Line contains a tab character.	24
	Line is longer than 80 characters.	25
	Line contains a tab character.	25
	Line contains a tab character.	26
	Line contains a tab character.	27
	Line contains a tab character.	28
	Line contains a tab character.	29
	Line contains a tab character.	30
	Line contains a tab character.	31
	Line contains a tab character.	32

au/com/loftinspace/utility/package.html

Error		Line
	Missing package documentation file.	0